Skip to content

Commit

Permalink
fix: Fix the Link List height being equal within the column layouts
Browse files Browse the repository at this point in the history
Merge pull request #338 from DFE-Digital/fix-link-list-height
  • Loading branch information
killij authored Nov 22, 2023
2 parents 5a4303a + 2a0a8fc commit 1de19c5
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Childrens-Social-Care-CPD/Views/Shared/_ColumnLayout.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@

@foreach (var group in Model.Items.Select((e, i) => new { ContentItem = e, Grouping = (i / Model.ColumnCount) }).GroupBy(e => e.Grouping))
{
<div class="govuk-grid-row">
<div class="govuk-grid-row column-layout-row">
@foreach (var item in group)
{
<div class="@gridClass govuk-!-margin-bottom-4">
<div class="@gridClass govuk-!-margin-bottom-4 column">
@{ await Html.RenderContentfulPartialAsync(item.ContentItem); }
</div>
}
Expand Down
3 changes: 2 additions & 1 deletion Childrens-Social-Care-CPD/styles/scss/application.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ $moj-images-path: "/assets/images/moj/";
@import "overrides/dfe-overrides";
@import "overrides/dfe-vertical-nav";
@import "overrides/govuk-overrides";
@import "overrides/site";
@import "overrides/site";
@import "components/ColumnLayout";
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.column-layout-row {
display: flex;
}

.column-layout-row .column {
display: flex;
}
7 changes: 7 additions & 0 deletions Childrens-Social-Care-CPD/wwwroot/css/application.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Childrens-Social-Care-CPD/wwwroot/css/application.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Childrens-Social-Care-CPD/wwwroot/css/application.min.css

Large diffs are not rendered by default.

Large diffs are not rendered by default.

0 comments on commit 1de19c5

Please sign in to comment.