[98] Integrate DfE sign in #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
steventux
force-pushed
the
98-integrate-dfe-signin
branch
4 times, most recently
from
30eb2e5
to
7d5dcb7
Compare
steventux
force-pushed
the
98-integrate-dfe-signin
branch
from
7d5dcb7
to
042affa
Compare
steventux
force-pushed
the
98-integrate-dfe-signin
branch
3 times, most recently
from
7f8362d
to
8579ca8
Compare
steventux
force-pushed
the
98-integrate-dfe-signin
branch
from
cf7a3d4
to
8579ca8
Compare
steventux
force-pushed
the
98-integrate-dfe-signin
branch
from
8579ca8
to
803d824
Compare
AbigailMcP
approved these changes
Aug 1, 2023
app/lib/hosting_environment.rb
Outdated
| @@ -0,0 +1,21 @@ | |||
| # frozen_string_literal: true | |||
| module HostingEnvironment | |||
| TEST_ENVIRONMENTS = %w[local dev test preproduction review].freeze | |||
There was a problem hiding this comment.
I think we just have %w[local test preproduction review]
| end | ||
|
|
||
| first_name { "Steven" } | ||
| last_name { "Toast" } |
Allow bypass of DSI sign in for specific environments and config.
There's an issue with using arbitrary action urls and govuk_button_to or
button_to when passing a block: url_for is called to generate the form action.
It seems passing an aribtrary path and a block is not possible.
Hence the form plain HTML to render the Sign in button with an SVG inside it.
steventux
force-pushed
the
98-integrate-dfe-signin
branch
from
803d824
to
a999910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
DsiUsermodel which is retrieved or created on successful callback from DSI.HostingEnvironmentlibrary to determine whether bypassing DSI is possible.Guidance to review
This can't be fully tested yet, we need some configuration on DSI.
Link to Trello card
https://trello.com/c/dfeaSkjW/98-integrate-dfe-signin
Checklist