Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[105] Add date of birth field to search form #57

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

AbigailMcP
Copy link
Contributor

@AbigailMcP AbigailMcP commented Jul 20, 2023

Context

As a user I want to be able to search by last name and date of birth and see whether there are any matching records.

Changes proposed in this pull request

  • Add date of birth field to form
  • Validate that the date of birth is a valid date via custom validator DayMonthYearValidator
  • Create InvalidDate class that returns a date-like-object which can be used to re-populate
    the form if an invalid date is given
  • Include date_of_birth where-clause in includes_record? method on ChildrensBarredListEntry
  • Display date_of_birth supplied by user in both Record found and No record found pages

Other:

  • Add breadcrumbs to results pages
  • Update curly apostrophes

Guidance to review

Form with date of birth field:

Screenshot 2023-07-21 at 12 35 36

Form with presence errors:

Screenshot 2023-07-21 at 12 35 46

Form with invalid date error:

Screenshot 2023-07-21 at 12 36 01

Record found page including date of birth and breadcrumbs:

Screenshot 2023-07-21 at 12 36 09

No record found page including date of birth and breadcrumbs:

Screenshot 2023-07-21 at 12 36 18

Link to Trello card

https://trello.com/c/HrfZNW9S/105-search-interface-date-of-birth-field

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

- Add date of birth field to form
- Validate that the date of birth is a valid date via custom validator DayMonthYearValidator
- Create InvalidDate class that returns a date-like-object which can be used to re-populate
  the form if an invalid date is given
@AbigailMcP AbigailMcP added the deploy Deploys a review app label Jul 20, 2023
@github-actions github-actions bot temporarily deployed to review-57 July 20, 2023 12:24 Destroyed
- Include date_of_birth where clause in `includes_record?` method on ChildrensBarredListEntry
- Display date_of_birth supplied by user in both Record found and No record found pages
@github-actions github-actions bot temporarily deployed to review-57 July 20, 2023 13:26 Destroyed
@github-actions github-actions bot temporarily deployed to review-57 July 20, 2023 14:43 Destroyed
@github-actions github-actions bot temporarily deployed to review-57 July 20, 2023 14:48 Destroyed
@AbigailMcP AbigailMcP marked this pull request as ready for review July 21, 2023 11:46
Copy link
Contributor

@steventux steventux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@AbigailMcP AbigailMcP merged commit b8b75c3 into main Jul 24, 2023
10 checks passed
@AbigailMcP AbigailMcP deleted the 105-date-of-birth-field branch July 24, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploys a review app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants