[97] Search interface - last name #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SearchesController with new and show actions - Add new.html.erb containing search form with last name input - Add show.html.erb with summary list rendering the result last_name - Update ApplicationController so that basic authentication used when service closed
- Create SearchForm to handle validations on the search parameters - Add presence validation to last_name field - Add error message to en.yml
- New includes_record? method in ChidrensBarredListEntry model which checks whether theres a matching record on the list - Use new includes_record? method in SearchesController and redirect to no_record page if none found - New no_record page - Install factorybot for system specs and tidy up rails_helper.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a user I want to be able to search the Children's Barred List by last name.
Changes proposed in this pull request
includes_record?method inChidrensBarredListEntrymodel whichchecks whether theres a matching record in the list
SearchesControllerwithnewandshowactionsshowperforms the search and redirects tono_recordif there are no matching recordsSearchFormto handle validations on the search parameters:Other:
service_openfeature to true.rails_helper.rbPagesControllerand routeOut of scope
Screenshots
Search page (current siting on the root "/"):
Search page with errors:
Record found page:
No record found page:
Guidance to review
Link to Trello card
https://trello.com/c/sNiptrzp/97-search-interface
Checklist