Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure exceptions app to use routes for errors controller #245

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

steventux
Copy link
Contributor

Context

Error pages are not currently rendering, the response status is correct though.

Changes proposed in this pull request

Configure exceptions app to use routes for errors controller. See https://github.com/DFE-Digital/access-your-teaching-qualifications/blob/b08144768992a078dff10cecfb9c4cf1f894376f/config/application.rb#L55 for how we do this elsewhere.

Guidance to review

Link to Trello card

https://trello.com/c/ePmS0RKY/1796-error-pages

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@steventux
Copy link
Contributor Author

Error pages

@steventux steventux merged commit 318c291 into main Feb 7, 2024
11 checks passed
@steventux steventux deleted the 1796-error-pages branch February 7, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants