Care 767 create automation tests for menu button on mobile #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added Test scripts to validate Menu button that replaces navigation Bar in the Mobile devices 2. Updated the Playwright config(both) to specifically run tests on a mobile viewport for Android devices. 3. Cleaned up the code by separating the repeatable shared functionalities, such as the 'You need help now' section, the website name, and the navigation bar.
KaraokeStu
reviewed
Mar 4, 2025
| async verifyShareButtonsVisibility() { | ||
| await Promise.all([ | ||
| expect(this.shareButtonsContainer).toBeVisible(), | ||
| expect(this.facebookShareButton).toBeVisible(), |
There was a problem hiding this comment.
As these are configurable, did we want to only expect the shareButtonsContainer, and leave the others?
There was a problem hiding this comment.
I have removed all the social buttons validations, I have kept the print icon as you mentioned that this should always be there
harryy94
approved these changes
Mar 4, 2025
varshakrishna-hippo
deleted the
CARE-767-Create-AutomationTests-for-Menu-button-on-Mobile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added More tests to validate Share buttons and Metadata section