Remove broken attempt to find hostname on Linux #1935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This snippet didn't work on Linux, at least for me: instead of returning a hostname, the shell snippet returned multiple lines which could not be resolved. Hypothesis: the default behaviour of not specifying the Capybara host will result in a sensible default of localhost. By setting server_host iff the environment variable is set, we can fall back to Capybara's reasonable default.
|
|
Fixing on a local machine breaks the CI, so I'm withdrawing this and just setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This snippet didn't work on Linux, at least for me: instead of returning a hostname, the shell snippet returned multiple lines which could not be resolved.
Hypothesis: the default behaviour of not specifying the Capybara host will result in a sensible default of localhost. By setting
server_hostiff the environment variable is set, we can fall back to Capybara's reasonable default.Changes in this PR
Removes the shell snippet used to find the Capybara hostname on Linux and the
127.0.0.1used otherwise, and does not configureserver_hostat all unless explicitly set via theCAPYBARA_SERVER_HOSTenvironment variable. As Capybara starts the server, it does not usually need help to find it.