Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove teacher degree apprenticeship feature flag code #9913

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Remove teacher degree apprenticeship feature flag code #9913

merged 2 commits into from
Oct 11, 2024

Conversation

tomas-stefano
Copy link
Collaborator

@tomas-stefano tomas-stefano commented Oct 11, 2024 •
edited
Loading

Context

With the start of 2025 we don't need the teacher degree apprenticeship feature flag anymore.
Remove of the teacher degree apprenticeship feature flag code checks and making the TDA the default behaviour.

Guidance to review

  1. Is there anything feature flag related checks left in the code that it shouldn't be?
  2. If you select you have no A levels is the content for postgraduate and undergraduate appears?
  3. When you add degrees (or delete all of them), does the new "do you have a degree" question appear?
  4. Did you spot any bug when submitting an undergraduate course?

@tomas-stefano tomas-stefano added the deploy_v2 Deploy the review app to AKS label Oct 11, 2024
@tomas-stefano
Copy link
Collaborator Author

Remove the TDA feature flag from Apply/Manage

@github-actions github-actions bot temporarily deployed to review_aks-9913 October 11, 2024 08:47 Destroyed
@tomas-stefano tomas-stefano mentioned this pull request Oct 11, 2024
Merged
@tomas-stefano tomas-stefano changed the title Remove teacher degree apprenticeship feature flag Remove teacher degree apprenticeship feature flag code Oct 11, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9913 October 11, 2024 09:04 Destroyed
@tomas-stefano tomas-stefano force-pushed the 2498-remove-the-tda-feature-flag-from-apply-manage branch from d17448e to 29850b3 Compare October 11, 2024 09:27
@github-actions github-actions bot temporarily deployed to review_aks-9913 October 11, 2024 09:31 Destroyed
@tomas-stefano tomas-stefano marked this pull request as ready for review October 11, 2024 09:54
@github-actions github-actions bot temporarily deployed to review_aks-9913 October 11, 2024 10:00 Destroyed
@tomas-stefano tomas-stefano merged commit 54617ba into main Oct 11, 2024
24 checks passed
@tomas-stefano tomas-stefano deleted the 2498-remove-the-tda-feature-flag-from-apply-manage branch October 11, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elceebee elceebee elceebee approved these changes

Assignees
No one assigned
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomas-stefano @elceebee