Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore international column on ApplicationQualifications #9898

Closed
wants to merge 2 commits into from

Conversation

inulty-dfe
Copy link
Collaborator

@inulty-dfe inulty-dfe commented Oct 7, 2024

Context

The field international in the applications_qualifications table is no longer used. it is false for all qualifications after 2022. We do not update it when someone creates a non uk qualification. Instead we use the presence of non_uk_qualification_type (string) as a proxy for the qualification being from another country.

Having an unused field like this is noisy and causes confusion when collecting and analysing data.

Changes proposed in this pull request

Ignore the international column
Regenerate the analytics blocklist

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@inulty-dfe
Copy link
Collaborator Author

@inulty-dfe
Copy link
Collaborator Author

I don't think this has been correctly identified as a field we can remove without a significant investigation into how it's used.

Closing this PR and put the ticket into Triage.

@inulty-dfe inulty-dfe closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant