-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Candidate Detail endpoint to CandidateAPI #9614
Merged
dcyoung-dev
merged 7 commits into
main
from
dy-add-a-candidate-detail-endpoint-to-the-candidate-api
Aug 2, 2024
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
245c91f
Added `/candidates/:candidate_id` endpoint to CandidateAPI
dcyoung-dev 12af25c
Refactored Candidate Serializer query method
dcyoung-dev aa837cb
Removed duplicated serializer calculation
dcyoung-dev 6f5a155
Refactored queries to serializer
dcyoung-dev 0e00360
Added error handling for 404 not found errors
dcyoung-dev 7737c73
undo minor change
dcyoung-dev ee3da3e
Rubocop fix
dcyoung-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,6 @@ | ||
module CandidateAPI | ||
module Serializers | ||
class V13 < Base | ||
def serialize(candidates) | ||
super.map do |candidate| | ||
candidate[:attributes][:application_forms].each do |form| | ||
application_form = ApplicationForm.find(form[:id]) | ||
form.merge!( | ||
application_choices: serialize_application_choices(application_form), | ||
references: serialize_references(application_form), | ||
qualifications: serialize_qualifications(application_form), | ||
personal_statement: serialize_personal_statement(application_form), | ||
) | ||
end | ||
|
||
candidate | ||
end | ||
end | ||
|
||
def query | ||
Candidate | ||
.left_outer_joins(application_forms: { application_choices: %i[provider course interviews], application_references: [], application_qualifications: [] }) | ||
.includes(application_forms: { application_choices: %i[provider course course_option interviews], application_qualifications: [], application_references: [] }) | ||
.where('candidates.updated_at > :updated_since OR application_forms.updated_at > :updated_since OR application_choices.updated_at > :updated_since OR "references".updated_at > :updated_since OR application_qualifications.updated_at > :updated_since', updated_since:) | ||
.where('application_forms.recruitment_cycle_year = ? OR candidates.created_at > ?', RecruitmentCycle.current_year, CycleTimetable.apply_deadline(RecruitmentCycle.previous_year)) | ||
.order(id: :asc) | ||
.distinct | ||
end | ||
Comment on lines
-3
to
-28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was an exact copy of the V12 implementation |
||
class V13 < V12 | ||
|
||
private | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
defaults api_version: CandidateAPISpecification::CURRENT_VERSION do | ||
namespace :candidate_api, path: 'candidate-api(/:api_version)', api_version: /v[.0-9]+/, constraints: ValidCandidateApiRoute do | ||
get '/candidates' => 'candidates#index' | ||
get '/candidates/:candidate_id' => 'candidates#show' | ||
end | ||
end |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just posting the query to help my future me.