-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[409] end of cycle implement a single deadline for all candidates #9503
Merged
elceebee
merged 15 commits into
main
from
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
Jun 27, 2024
Merged
[409] end of cycle implement a single deadline for all candidates #9503
elceebee
merged 15 commits into
main
from
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elceebee
force-pushed
the
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
branch
from
June 26, 2024 08:21
95e347e
to
e146613
Compare
elceebee
force-pushed
the
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
branch
from
June 26, 2024 08:22
e146613
to
b937e81
Compare
elceebee
force-pushed
the
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
branch
from
June 26, 2024 08:48
b937e81
to
a66fc38
Compare
elceebee
force-pushed
the
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
branch
from
June 26, 2024 10:37
a66fc38
to
530ed9f
Compare
elceebee
changed the title
DRAFT 409 end of cycle implement a single deadline for all candidates
[409] end of cycle implement a single deadline for all candidates
Jun 26, 2024
spec/workers/send_eoc_deadline_reminder_email_to_candidates_worker_spec.rb
Show resolved
Hide resolved
This included updated the duplicate application service which had some knock on effects for other tests, but given we don't have applications with phase 'apply_2' there are no consequences in the real world
elceebee
force-pushed
the
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
branch
from
June 27, 2024 08:32
ee5b4d6
to
f1d2c5e
Compare
elceebee
force-pushed
the
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
branch
from
June 27, 2024 09:02
bac7e26
to
83c3615
Compare
elceebee
deleted the
409-end-of-cycle-implement-a-single-deadline-for-all-candidates
branch
June 27, 2024 14:05
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This card to remove the 'apply_2' deadline was created in July last year during the continuous application work. Now that we have started doing the end of cycle work again this year, it is apparent that this apply_1 and apply_2 logic creates confusion and should be removed before we move forward.
Changes proposed in this pull request
Broadly, the PR just:
CycleTimeable
service to remove the distinction between the two deadlines.For backward compatibility, I have retained the apply_1 and apply_2 deadlines on those cycles where it was relevant.
What IS NOT in this PR (tickets to be written for the following):
Guidance to review
I've got the test suite passing and I've done lots of manual testing locally. Would appreciate other people to do lots of clicking and see if I've broken anything.
It's a big PR, so best to review commit by commit.
Link to Trello card
https://trello.com/c/FPph5syu
Things to check