Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1842] Update end-of-cycle banner content and conditions for rendering #9496

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jun 21, 2024

Context

The End-of-cycle gets underway on the 1 July. The first thing is that candidates with unsuccessful applications will see this banner on their application dashboard and candidate details page.

Changes proposed in this pull request

We are very soon going to do away with the apply_1 and apply_2 distinctions. But because of the time sensitivity with this ticket, we have had to work within the existing structure, using the apply_2 deadline as the apply_deadline.

I have deleted all the 'phase' related queries as phase is now irrelevant.

Before After
image image

Guidance to review

The preview is at /view_components/candidate_interface/summer_recruitment_banner_component/twenty_twenty_four

locally

Link to Trello card

https://trello.com/c/OHHgoRn8

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

@elceebee elceebee changed the title Update end-of-cycle banner content and conditions for rendering [1842] Update end-of-cycle banner content and conditions for rendering Jun 21, 2024
@elceebee elceebee force-pushed the 1842-update-summer-recruitment-banner-text branch from 52ff982 to 5d25170 Compare June 21, 2024 14:38
@elceebee elceebee force-pushed the 1842-update-summer-recruitment-banner-text branch from 5d25170 to 2e20437 Compare June 21, 2024 14:54
@elceebee elceebee force-pushed the 1842-update-summer-recruitment-banner-text branch from 2e20437 to 2f8ea28 Compare June 21, 2024 15:01
@elceebee elceebee marked this pull request as ready for review June 21, 2024 15:03
@elceebee elceebee requested a review from a team June 21, 2024 15:04
@elceebee
Copy link
Contributor Author

Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/system/candidate_interface/offers_and_withdrawals/candidate_accepts_offer_spec.rb:7: ⚠️ Ambiguous match, found 2 elements matching visible link or button "Lind College"

@elceebee elceebee force-pushed the 1842-update-summer-recruitment-banner-text branch from 360922e to 878f9e6 Compare June 24, 2024 08:36
@elceebee elceebee merged commit edb2965 into main Jun 24, 2024
23 checks passed
@elceebee elceebee deleted the 1842-update-summer-recruitment-banner-text branch June 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants