Drop the data ignored column from the DataExport model #9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now that we've dropped the database column, we can safely remove the ignored column from our model.
This is the final step, step 3, to drop the data column entirely.
Step 1 - Ignore the
datacolumn in our modelStep 2 - Migration to remove the column
Step 3 - Remove the
ignore_columnscallChanges proposed in this pull request
self.ignored_columns += %w[data]from theDataExportmodel.Guidance to review
Refer to #9486 for Step 2.