Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1711] Drop mid cycle report tables #9460

Merged
merged 2 commits into from
Jun 12, 2024
Merged

[1711] Drop mid cycle report tables #9460

merged 2 commits into from
Jun 12, 2024

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jun 12, 2024

Context

see: #9459

Changes proposed in this pull request

Guidance to review

Link to Trello card

https://trello.com/c/YAxdUd1t

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

@elceebee elceebee changed the title Drop mid cycle report tables [1711] Drop mid cycle report tables Jun 12, 2024
@elceebee elceebee marked this pull request as ready for review June 12, 2024 12:41
@elceebee
Copy link
Contributor Author

Base automatically changed from 1711-remaining-clean-up-for-recruitment-performance-report-remove-data to main June 12, 2024 14:36
@elceebee elceebee changed the base branch from main to 1711-drop-models June 12, 2024 15:47
Base automatically changed from 1711-drop-models to main June 12, 2024 15:57
@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Jun 12, 2024
@elceebee elceebee self-assigned this Jun 12, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9460 June 12, 2024 16:02 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-9460 June 12, 2024 16:15 Destroyed
@elceebee elceebee merged commit 8f9ea76 into main Jun 12, 2024
23 checks passed
@elceebee elceebee deleted the 1711-drop-tables branch June 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants