Add teacher degree apprenticeship filter to Manage

[tomas-stefano]

Context

We need to make changes to Manage to allow providers to view applications with the a new type “Teacher degree apprenticeship (TDA) with QTS”.

Changes proposed in this pull request

• Added a new filter for TDA courses (when apply the filters when user select)

Course type

[ ] Postgraduate courses
[ ] Teaching degree apprenticeship (TDA) courses

Guidance to review

If you want to test:

1. Enable the feature flag in the review app
2. Create a TDA course (see spec/factories/course trait TDA)
3. Apply for a TDA course
4. Then filter for TDA and non TDA applications in Manage

Trello card

https://trello.com/c/HIsIqv1q/1728-add-filters-to-manage-for-tda

[github-actions]

Database-level enum changes detected

Please include a data migration for these attributes and values:

12c12
< <enum> Course.program_type: ["HE", "HES", "SD", "SS", "SC", "SSC", "TA"]
---
> <enum> Course.program_type: ["HE", "HES", "SD", "SS", "SC", "SSC", "TA", "TDA"]

[elceebee]

Suggested change

	description { 'Teacher degree apprenticeship with QTS full time teaching apprenticeship' }
	description { 'Teaching degree apprenticeship with QTS full time teaching apprenticeship' }

Is it Teaching degree apprenticeship or Teacher degree apprenticeship? We are not consistent. it may be too late to change in some places (eg the programme_type), but we should make an effort where possible.

[tomas-stefano]

Actually this comes from the content designer and from the prototype. I might keep as it is

[tomas-stefano]

Add filters to Manage for TDA

[dcyoung-dev]

A couple of suggestions wordings 👌

[avinhurry]

A couple of minor questions/suggestions but looks good, nice work 👍🏼

[avinhurry]

Is this adding value? If we add another filter this will fail?

[tomas-stefano]

i just maintaned the same test that was there and added the tda filter. I think I will maintain this.