Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecruitmentReportScheduler accepts explicit cycle_week argument #9368

Merged
merged 1 commit into from
May 16, 2024

Conversation

inulty-dfe
Copy link
Collaborator

Context

Add default param to the Recruitment Performance Report Scheduler to allow us to run the report scheduler for arbitrary cycle_weeks.

Changes proposed in this pull request

Give us more control to run the RecruitmentPerformanceReportScheduler from the console

Guidance to review

Link to Trello card

Trello Ticket

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

  This will allow us to run the scheduler for arbitrary weeks from the
  console.
@inulty-dfe inulty-dfe added the deploy_v2 Deploy the review app to AKS label May 15, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9368 May 15, 2024 16:37 Destroyed
@inulty-dfe inulty-dfe marked this pull request as ready for review May 15, 2024 16:42
@inulty-dfe inulty-dfe requested a review from elceebee May 15, 2024 16:42
Copy link
Contributor

@elceebee elceebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@@ -1,12 +1,18 @@
module Publications
class RecruitmentPerformanceReportScheduler
def initialize(cycle_week: CycleTimetable.current_cycle_week.pred)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what is pred?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

predecessor. It's the number before. Opposite of succ

@inulty-dfe inulty-dfe merged commit 183fc85 into main May 16, 2024
47 checks passed
@inulty-dfe inulty-dfe deleted the pass-cycle-week-to-report-scheduler branch May 16, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants