-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Providers Reports index #9359
Conversation
Add Recruitment Performance report Show mid-cycle / recruitment performance based on FeatureFlag Add specs for single / multiple providers
0d6795b
to
90dc2a5
Compare
This method gives us the ability to get the first and last day of a cycle_week. Also make change to .start_of_cycle_week - The first day of the first cycle_week should be Monday, even if that day is not in the cycle
- use :govuk_date to display the last date the report comprises
8f80578
to
cc57bf2
Compare
@@ -2,5 +2,9 @@ module Publications | |||
class ProviderRecruitmentPerformanceReport < ApplicationRecord | |||
belongs_to :provider | |||
validates :cycle_week, :publication_date, presence: true | |||
|
|||
def reporting_date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name of this one is confusing. I would think 'reporting date' would be the date the report was created, which is the publications date. Maybe reporting_end_date
. report_range_end_date
<% if FeatureFlag.active?(:recruitment_performance_report) %> | ||
<% if @performance_reports %> | ||
<h2 class="govuk-heading-m"> | ||
Weekly recruitment performance report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be consistent with the locales and put this in a locale file. (same for the other text on this page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this locally and it all looks good to me. I have a couple of minor suggestions, but they are not blockers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Context
Update the reports section in the Provider Interface to show link to the new Recruitment Performance Report and remove the link to the old mid-cycle report
Changes proposed in this pull request
The page has multiple potential states. The context is always for a particular provider user.
One provider for the user
Multiple providers for the user
In order to calculate the date up to which the report counts candidates, I've added
CycleTimetable.cycle_week_date_range
. We can get the first and last day of the cycle week from this method as a bonus.Guidance to review
Providers 8 and 1 have recruitment performance reports generated for them
https://apply-review-9359.test.teacherservices.cloud/support/providers/8/users
Link to Trello card
Trello Ticket
Things to check