Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement RecruitmentCycle::CYCLE #8448

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

inulty-dfe
Copy link
Collaborator

Context

  • Make it a module method
  • The single positional argument sets the limit on the labels generated

Changes proposed in this pull request

Reimplement the RecruitmentCycle constant CYCLE as a module method. avoids the need to manually add a new recruitment cycle each year.

Guidance to review

Is there a specific period during the Recruitment Cycle when the next years cycle should appear?

Link to Trello card

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

  Make it a module method
  The single positional argument sets the limit on the labels generated
@inulty-dfe inulty-dfe marked this pull request as ready for review August 9, 2023 12:44
@inulty-dfe inulty-dfe merged commit 08c7b42 into main Aug 22, 2023
37 checks passed
@inulty-dfe inulty-dfe deleted the reimplement-cycle-dates branch August 22, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants