Skip to content

Commit

Permalink
Refactored conditional return for #completing_qualification
Browse files Browse the repository at this point in the history
Added a `#exclude_completing_qualification?` method to improve readability
  • Loading branch information
dcyoung-dev committed Jul 17, 2024
1 parent c25daab commit ec64302
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions app/presenters/concerns/qualification_api_data.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ def include_completing_qualification?
false
end

def exclude_completing_qualification?
!include_completing_qualification?
end

def qualifications_of_level(level)
application_form.application_qualifications.select do |qualification|
qualification.level == level
Expand Down Expand Up @@ -151,18 +155,20 @@ def structured_gcse_to_hashes(gcse)
private

def completing_qualification(qualification)
return {} unless include_completing_qualification?
return {} if exclude_completing_qualification?

if qualification.gcse?
return {
currently_completing_qualification: qualification[:currently_completing_qualification],
missing_explanation: qualification[:missing_explanation],
other_uk_qualification_type: qualification[:other_uk_qualification_type],
}
end
return completing_gcse(qualification) if qualification.gcse?

{
other_uk_qualification_type: qualification[:other_uk_qualification_type],
}
end

def completing_gcse(gcse_qualification)
{
currently_completing_qualification: gcse_qualification[:currently_completing_qualification],
missing_explanation: gcse_qualification[:missing_explanation],
other_uk_qualification_type: gcse_qualification[:other_uk_qualification_type],
}
end
end

0 comments on commit ec64302

Please sign in to comment.