Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Feature/academies api contracts #10

Merged
merged 3 commits into from
Nov 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<RepositoryUrl>https://github.com/DFE-Digital/academisation-nuget-packages</RepositoryUrl>
<RepositoryType>git</RepositoryType>
<Version>1.0.3</Version>
<AssemblyVersion>1.0.4</AssemblyVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
22 changes: 22 additions & 0 deletions academiesContracts/Dfe.Academies.Contracts/V4/AddressDto.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
namespace Dfe.Academies.Contracts.V4;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

[Serializable]
public class AddressDto
{
public string Street { get; set; }

Check warning on line 11 in academiesContracts/Dfe.Academies.Contracts/V4/AddressDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'Street' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

public string Town { get; set; }

Check warning on line 13 in academiesContracts/Dfe.Academies.Contracts/V4/AddressDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'Town' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

public string County { get; set; }

Check warning on line 15 in academiesContracts/Dfe.Academies.Contracts/V4/AddressDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'County' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

public string Postcode { get; set; }

public string Locality { get; set; }

public string Additional { get; set; }
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
namespace Dfe.Academies.Contracts.Establishments;

using Dfe.Academies.Contracts.Trusts;
namespace Dfe.Academies.Contracts.V4.Establishments;

[Serializable]
public class EstablishmentDto
Expand Down Expand Up @@ -59,6 +57,6 @@
[Serializable]
public class CensusDto
{
public string NumberOfPupils { get; set; }

Check warning on line 60 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'NumberOfPupils' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string PercentageFsm { get; set; }

Check warning on line 61 in academiesContracts/Dfe.Academies.Contracts/V4/Establishments/EstablishmentDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'PercentageFsm' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
namespace Dfe.Academies.Contracts.V4;
using System.Collections.Generic;

[Serializable]
public class PagedDataResponse<TResponse> where TResponse : class
{

Expand All @@ -18,6 +19,8 @@ public PagedDataResponse(IEnumerable<TResponse> data, PagingResponse pagingRespo
public PagedDataResponse(TResponse data) => Data = new List<TResponse> { data };

}

[Serializable]
public class PagingResponse
{
public int Page { get; set; }
Expand Down
18 changes: 1 addition & 17 deletions academiesContracts/Dfe.Academies.Contracts/V4/Trusts/TrustDto.cs
Original file line number Diff line number Diff line change
@@ -1,32 +1,16 @@
namespace Dfe.Academies.Contracts.Trusts;
namespace Dfe.Academies.Contracts.V4.Trusts;

[Serializable]
public class TrustDto
{
public string Name { get; set; }

Check warning on line 6 in academiesContracts/Dfe.Academies.Contracts/V4/Trusts/TrustDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

public string Ukprn { get; set; }

Check warning on line 8 in academiesContracts/Dfe.Academies.Contracts/V4/Trusts/TrustDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'Ukprn' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

public string CompaniesHouseNumber { get; set; }

Check warning on line 10 in academiesContracts/Dfe.Academies.Contracts/V4/Trusts/TrustDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'CompaniesHouseNumber' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

public string ReferenceNumber { get; set; }

Check warning on line 12 in academiesContracts/Dfe.Academies.Contracts/V4/Trusts/TrustDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'ReferenceNumber' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

public AddressDto Address { get; set; }

Check warning on line 14 in academiesContracts/Dfe.Academies.Contracts/V4/Trusts/TrustDto.cs

View workflow job for this annotation

GitHub Actions / build

Non-nullable property 'Address' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.

}

[Serializable]
public class AddressDto
{
public string Street { get; set; }

public string Town { get; set; }

public string County { get; set; }

public string Postcode { get; set; }

public string Locality { get; set; }

public string Additional { get; set; }
}
Loading