Update model tests to use before block #1545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#128 This PR is part of our ongoing work to make unit tests faster, more efficient and less flakey, focusing on the model unit tests. We are simplifying the database seeding process by moving it to a top-level before block instead of using beforeEach. Since the model unit tests check the relationships between table models, putting all the test data in one place means we only need to seed the database once instead of before each test. By seeding less data into the test database, our hope is that the tests run faster, the code is cleaner, and they are less flakey due to conflicting test data.
Beckyrose200
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#128
This PR is part of our ongoing work to make unit tests faster, more efficient and less flakey, focusing on the model unit tests.
We are simplifying the database seeding process by moving it to a top-level before block instead of using beforeEach. Since the model unit tests check the relationships between table models, putting all the test data in one place means we only need to seed the database once instead of before each test. By seeding less data into the test database, our hope is that the tests run faster, the code is cleaner, and they are less flakey due to conflicting test data.