Add default for multiple upload on return version journey #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4707 As part of the quarterly returns submissions work, we need to default the multiple uploads additional option to true when the licence is for a water company.
jonathangoulding
force-pushed
the
feature-return-version-multiple-upload-default-when-water-company
branch
from
a6a9913
to
f6849ce
Compare
…lt-when-water-company
Cruikshanks
requested changes
Nov 6, 2024
app/presenters/return-versions/setup/additional-submission-options.presenter.js
Outdated
Show resolved
Hide resolved
test/presenters/return-versions/setup/additional-submission-options.presenter.test.js
Outdated
Show resolved
Hide resolved
| describe('the "additionalSubmissionOptions" property', () => { | ||
| describe('when the user has previously submitted additional submission options', () => { | ||
| describe('the "multipleUpload" property', () => { | ||
| describe('when a user has selected "multipleUpload" for additional options', () => { |
There was a problem hiding this comment.
We seem to have dropped the word 'previously' from these tests. It was there to try and highlight where a user has previously visited this page and submitted an option, then we expect the presenter to replay it.
Happy to change it to something else if it's not making that clear. But I think just dropping it makes it unclear we are talking about selections a user previously made, instead of ones they have just made.
There was a problem hiding this comment.
I have updated to reflect the previous state setting and the default being set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4707
As part of the quarterly returns submissions work, we need to default the multiple uploads additional option to true when the licence is for a water company.