Update use previous in ret. req setup with mod log #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4640 > Part of the work to display a licence's history to users (mod log) In [Update view return version to include mod log info](#1261), we updated the view return version page to include details taken from a return version's mod log history. Then in [Update return versions table with reasons in view](#1281) we updated the table of return requirements in the view licence setup tab to display the mod log reason for return versions without a mapping. The final place we display return version reasons is the 'Use previous requirements for returns' page in the return version set up journey. This change updates the logic so for return versions without a reason but that have a mod log with a reason, we use its description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4640
In Update view return version to include mod log info, we updated the view return version page to include details taken from a return version's mod log history.
Then, in Update return versions table with reasons in view, we updated the table of return requirements in the view licence setup tab to display the mod log reason for return versions without a mapping.
The final place we display return version reasons is the 'Use previous requirements for returns' page in the return version set-up journey.
This change updates the logic for return versions without a reason but that have a mod log with a reason: we use its description.