Configured Financial_Year from CalRun #78
+68
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udaydefra
reviewed
Nov 7, 2024
| using (var transaction = this.context.Database.BeginTransaction()) | ||
| { | ||
| try | ||
| { | ||
| var stagingOrganisationData = this.wrapper.GetOrganisationData(); | ||
| var calcOrganisationMaster = new CalculatorRunOrganisationDataMaster | ||
| { | ||
| CalendarYear = Util.GetCalendarYear("2024-25"), //Take the financial year from Calc Run table and Derive the Calendar year |
There was a problem hiding this comment.
Please add a unit test for this
There was a problem hiding this comment.
@udaydefra - Added Unit Tests
johnbenjamin-defra
requested changes
Nov 7, 2024
| @@ -24,7 +24,7 @@ public class CalculatorRun | |||
| [Column("financial_year")] | |||
| [StringLength(250)] | |||
| [Required] | |||
| public string Financial_Year { get; set; } | |||
| public string financialYear { get; set; } | |||
There was a problem hiding this comment.
The property should be Pascal cased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configured Financial_Year from CalRun