Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User pagination settings #61

Merged
merged 3 commits into from
Oct 12, 2023
Merged

User pagination settings #61

merged 3 commits into from
Oct 12, 2023

Conversation

kunfang98927
Copy link
Contributor

  • Create a modal window for pagination setting
  • Save pagination settings in localStorage
  • Pagination setting input validation (avoid invalid values)

@kunfang98927
create pagination modal window
f25a871 
* Create modal window for pagination setting
* Basic styles
* Save pagination settings in localStorage
* To-do: input validation; page-link href (with paginate_by)
@kunfang98927
update pagination settings
837c633
@kunfang98927 kunfang98927 merged commit 5b1da09 into develop Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchiller dchiller dchiller approved these changes

@yinanazhou yinanazhou Awaiting requested review from yinanazhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunfang98927 @dchiller