Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "Add new instrument name"; Initialize "Upload image"; #164

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Support "Add new instrument name"; Initialize "Upload image"; #164

wants to merge 13 commits into from

Commits on Aug 29, 2024

  1. feat: initialize image upload UI 

    - remove "instrument-detail" page
- add two buttons on each instrument card: "Upload new images" & "View on wikidata"
- initialize image upload modal UI

Refs: #150
    @kunfang98927
    kunfang98927 committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    aa13e25 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. fix: update "upload img" init & remove unused css 

    Refs: #150
    @kunfang98927
    kunfang98927 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    eaca2c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. feat: initialize image upload UI 

    - remove "instrument-detail" page
- add two buttons on each instrument card: "Upload new images" & "View on wikidata"
- initialize image upload modal UI

Refs: #150
    @kunfang98927
    kunfang98927 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4af1fee View commit details
    Browse the repository at this point in the history

  2. fix: update "upload img" init & remove unused css 

    Refs: #150
    @kunfang98927
    kunfang98927 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e85db70 View commit details
    Browse the repository at this point in the history

  3. fix: add "description" & "alias" fields into InstrumentName model 

    - add "description" & "alias" fields into InstrumentName model;
- fix "Non classifiés" in facet search;
- support only English and French in facet search;
- fix a bug: replace `active_language.en_label == "french"` with `... "French"`;

Refs: #160 #161
    @kunfang98927
    kunfang98927 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6c04418 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'img-upload' of https://github.com/DDMAL/VIM into img-up… 

    …load
    @kunfang98927
    kunfang98927 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b29e655 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. feat: add new instrument name 

    - add new instrument name, source, description, and alias by a modal;
- optionally publish to wikidata;

Refs: #163
    @kunfang98927
    kunfang98927 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    364ff92 View commit details
    Browse the repository at this point in the history

  2. fix: prettier fix 

    Refs: #163
    @kunfang98927
    kunfang98927 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4539e3c View commit details
    Browse the repository at this point in the history

  3. fix: update prettier version in pre-commit

    @kunfang98927
    kunfang98927 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f564ffb View commit details
    Browse the repository at this point in the history

  4. fix: keep prettier version same as pre-commit

    @kunfang98927
    kunfang98927 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fe5801c View commit details
    Browse the repository at this point in the history

  5. fix: update instrument list (add percussions) 

    Refs: #165
    @kunfang98927
    kunfang98927 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    888e84b View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. fix: refactor code for "add instrument name" 

    - remove "alias" field from "InstrumentName" model;
- move "publish_name" to a separate .py file
- use "csrf_protect" decorator for "publish_name"
- extract the common code in "mansonryView.html" and "stdView.html"

Refs: #163
    @kunfang98927
    kunfang98927 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8079346 View commit details
    Browse the repository at this point in the history

  2. fix: refactor code for "add instrument name" 

    Ref: #163
    @kunfang98927
    kunfang98927 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bac2cc0 View commit details
    Browse the repository at this point in the history