Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dashboard with file system #1047

Merged
merged 56 commits into from
Jul 24, 2023
Merged

Implement dashboard with file system #1047

merged 56 commits into from
Jul 24, 2023

Conversation

chetbae
Copy link
Contributor

@chetbae chetbae commented Jul 6, 2023

closes #1004.

Dashboard that allows users to create folders to categorize and organize documents.

neon-chetbae.vercel.app

@chetbae chetbae self-assigned this Jul 6, 2023
@chetbae chetbae linked an issue Jul 6, 2023 that may be closed by this pull request
@chetbae
Copy link
Contributor Author

chetbae commented Jul 6, 2023

closes #1040 101e238
closes #1041 de779a0
closes #1042 0e34f67
closes #1043 186947b
closes #1044 af33b22 and 76faf99
closes #1045 ...
closes #1046 ...

@chetbae chetbae changed the title Implement dashboard with file system WIP Implement dashboard with file system Jul 6, 2023
@chetbae chetbae changed the title WIP Implement dashboard with file system Implement dashboard with file system Jul 13, 2023
@chetbae
Copy link
Contributor Author

chetbae commented Jul 17, 2023

Red: 🆘

  • Cannot add new folder in empty parent folder 📁🚫
  • Move-to from contextmenu 🚗💨
  • Improved error messages for dropping folders

Yellow: ⚠️

  • Styling/icon indicating folders are folders and files are files 🙈
  • Multiple Drag 👯‍♀️

Green: 💹

  • Sorting dashboard by name or date 📚
  • History stack: undo/redo ...(something like { path: IFolder array, state: IFolder root clone }) 🧠

@chetbae
Copy link
Contributor Author

chetbae commented Jul 21, 2023

https://neon-aibobgz7p-chetbae.vercel.app/dashboard.html

Snapshot of the full pr! Few things not implemented such as sorting and multiple drag, which were not absolutely necessary but a nice user experience for the folder system. Would love to keep working this on the side while developing VIM though!

@JoyfulGen @yinanazhou @cadagong How does this look to merge into prod?

@chetbae
Copy link
Contributor Author

chetbae commented Jul 21, 2023

P.S. I tested going from develop (flat dashboard) with uploaded files in pouchDB → to dashboard-folder-impl (file system). Previous uploads go to the root folder.

The code for the transfer is in FileSystemManager.ts line 25, the logic goes like this:

if file-system state exists in local storage:
    load local storage state
else:
    create new root folder
    add samples folder to root
    get previous uploads from pouch db (if any)
    load newly created root folder

So hundreds of corrected folios won't be lost! If neon's domain ever changes, that's a different problem.

@JoyfulGen
Copy link
Contributor

@JoyfulGen @yinanazhou @cadagong How does this look to merge into prod?

It looks fantastic! Everything works very smoothly and it's an excellent system thank you :)))

Copy link
Member

@yinanazhou yinanazhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chetbae chetbae merged commit 47f3c3f into develop Jul 24, 2023
3 checks passed
@chetbae chetbae deleted the dashboard-folder-impl branch July 24, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: folder level in file upload page
4 participants