Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX 52 - 나눔 전체 내역 조회 조건문 변경 #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jiwon-cho
Copy link
Collaborator

Pull Request

작업 내용

이 PR은 다음과 같은 작업을 포함하고 있습니다:

  • 나눔 전체 내역 조회 조건문이 and 로 되어 조건이 잘못 먹어 변경함

변경 사항

다음과 같은 파일/부분을 수정했습니다:

  • src/main/kotlin/mara/server/domain/�share/ShareRepository.kt: findAllMyShare 쿼리문 조건 and 에서 or 로 변경
  • ...

테스트

다음과 같은 테스트를 수행했습니다:

  • 단위 테스트: `. Swagger 로 단위테스트 진행

@Jiwon-cho Jiwon-cho added the bug Something isn't working label Mar 1, 2024
@Jiwon-cho Jiwon-cho self-assigned this Mar 1, 2024
Copy link
Collaborator

@jhkang1517 jhkang1517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.exposedHeaders("*") 와 시연 설정만 원복하면 될 것 같습니다! 🦾

@@ -12,6 +12,7 @@ class CorsConfig : WebMvcConfigurer {
.allowedOriginPatterns("*") // 모든 도메인에 대해 액세스 허용
.allowedMethods("GET", "POST", "PUT", "PATCH", "DELETE", "OPTIONS") // 허용할 HTTP 메서드
.allowedHeaders("*") // 모든 헤더 허용
.exposedHeaders("*")
Copy link
Collaborator

@jhkang1517 jhkang1517 Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실제 header 값인 access token 과 refresh token , re-access token 등으로 변경하면 좋을 것 같습니다! 😄
Reference

@@ -35,7 +35,7 @@ cloud:

jwt:
secret-key: ${jwt-secret-key}
access-duration-mils: 1800000
access-duration-mils: 21600000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시연용 설정은 원복해서 다시 배포하는 것이 좋을 것 같습니다! 🎡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants