Adjust forget commands to respect the direction of engines #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sending the "backwards e-stop" packet to locos the CS will send the e-stop packet with the direction the locos should already have.
daniviga
pushed a commit
to daniviga/CommandStation-EX
that referenced
this pull request
Mar 26, 2023
Contribution updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #23, targeting the TrackManager branch instead of master, to get into the next major update, not a minor one.
Currently forgetting an engine that is still on the track (for example on a siding) will cause it to get a "backwards e-stop", potentially changing it's direction.
With this PR, the CS should send the e-stop packets with the correct direction.
DCC::forgetLococalls the setThrottle function twice - I'm not sure why, but assumed it's to ensure that the loco actually gets the packet, since it's not gonna get any reminders.DCC::forgetAllLocosdoesn't send it twice. Should I adjust one of them?