New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2320: simulate_replay fails to link related to dumpStack #2332

Merged

lifflander merged 10 commits into develop from 2320-simulate_replay-fails-to-link-related-to-dumpstack

Aug 7, 2024

Contributor

cwschilly commented Jul 31, 2024 •

edited

Loading

Fixes #2320

Problem

The issue was that there were two versions of libunwind available, and we were trying to link with the wrong one.

Solution

I've added a Findlibunwind.cmake module so we can use find_package(libunwind) instead of check_include_file.

This gives us more control over which libunwind is found. Specifically, we can provide HINTS that point to the desired libunwind installation (usually, we want the one installed in /usr)

I've added a libunwind_ROOT_DIR CMake variable that users can optionally provide during configuration. (This directory becomes the HINT passed to find_package)
If libunwind isn't found in the suggested directory, it searches using CMake's default path instead.

cwschilly linked an issue

that may be closed by this pull request

simulate_replay fails to link related to dumpStack #2320

Closed

cwschilly force-pushed the 2320-simulate_replay-fails-to-link-related-to-dumpstack branch from 45635fa to d463c84 Compare

July 31, 2024 16:34

cwschilly self-assigned this

github-actions bot commented Jul 31, 2024 •

edited

Loading

Pipelines results

PR tests (clang-13, alpine, mpich)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (clang-9, ubuntu, mpich)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (clang-12, ubuntu, mpich)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (clang-13, ubuntu, mpich)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (clang-14, ubuntu, mpich, verbose)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (clang-11, ubuntu, mpich)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (clang-10, ubuntu, mpich)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

Compilation - successful

Testing - passed

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

/vt/tests/perf/send_cost.cc(169): warning #177-D: variable "prevNode" was declared but never referenced
    auto const prevNode = (thisNode - 1 + num_nodes_) % num_nodes_;
               ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

Testing - passed

PR tests (intel icpc, ubuntu, mpich)

Build for c77ba38 (2024-08-06 14:28:51 UTC)

remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhi%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

cwschilly marked this pull request as draft

July 31, 2024 20:06

cwschilly marked this pull request as ready for review

July 31, 2024 20:29

cwschilly marked this pull request as draft

July 31, 2024 20:38

cwschilly marked this pull request as ready for review

August 1, 2024 20:50

cwschilly requested review from stmcgovern, lifflander, cz4rs, thearusable, JacobDomagala, ppebay, nlslatt and pierrepebay

August 2, 2024 13:21

cwschilly added 6 commits

August 2, 2024 13:12


          #2320: add Findlibunwind.cmake file

227fe09


          #2320: remove libunwind from check_system_functions

681e7db


          #2320: resolve unused parameter warning

4f3893a


          #2320: fix linking with unwind

d21f59f


          #2320: prioritize HINTS over CMake's default search path

731dd72


          #2320: fix spacing in build_cpp configuration

f958f15

cwschilly force-pushed the 2320-simulate_replay-fails-to-link-related-to-dumpstack branch from ded131d to f958f15 Compare

August 2, 2024 17:12

nlslatt reviewed

View reviewed changes

cmake-modules/Findlibunwind.cmake Show resolved Hide resolved

cwschilly added 2 commits

August 2, 2024 14:54


          #2320: fix typos in Findlibunwind.cmake and add notice of modification

b227539


          #2320: rework Findlibunwind.cmake

ec3dc2e

Contributor Author

cwschilly commented Aug 5, 2024

@nlslatt I've reworked Findlibunwind.cmake.

I deleted the previous version and then wrote a new one loosely following the logic from CMake's Find<package>.cmake modules (e.g. FindALSA.cmake).

nlslatt reviewed

View reviewed changes

cmake-modules/Findlibunwind.cmake Outdated Show resolved Hide resolved

cwschilly added 2 commits

August 6, 2024 10:26


          #2320: use both root and include/lib dirs as hints

21e4c5e


          #2320: add clarifying comment

c77ba38

nlslatt approved these changes

View reviewed changes

Collaborator

nlslatt left a comment

Looks good. Were you able to test the latest changes?

Contributor Author

cwschilly commented Aug 7, 2024 •

edited

Loading

Looks good. Were you able to test the latest changes?

@nlslatt Yes, I just tested this morning and everything is working properly.

cz4rs approved these changes

View reviewed changes

Contributor

cz4rs left a comment

Looks good to me.

lifflander approved these changes

View reviewed changes

lifflander merged commit 96689a3 into develop

26 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lifflander lifflander approved these changes

cz4rs cz4rs approved these changes

nlslatt nlslatt approved these changes

stmcgovern Awaiting requested review from stmcgovern

thearusable Awaiting requested review from thearusable

JacobDomagala Awaiting requested review from JacobDomagala

ppebay Awaiting requested review from ppebay

pierrepebay Awaiting requested review from pierrepebay

Labels

None yet