#2174: Integrate vt-tv api into lb data export #2294

pierrepebay · 2024-05-28T17:10:25Z

github-actions · 2024-05-28T21:26:46Z

Pipelines results

PR tests (gcc-12, ubuntu, mpich, verbose)

Build for ee31596 (2024-05-28 17:09:22 UTC)

FAILED: src/CMakeFiles/vt.dir/Unity/unity_20_cxx.cxx.o 
/usr/bin/ccache /usr/lib/ccache/g++ -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DVT_NO_COLOR_ENABLED -I/vt/lib/CLI -I/build/vt/release -I/vt/src -I/vt/lib/json/include -I/vt/lib/brotli/c/include -I/vt/lib/libfort/lib -isystem /vt/lib/fmt/include -isystem /vt/lib/EngFormat-Cpp/include -isystem /build/checkpoint/install/include -O3 -DNDEBUG -Wall -pedantic -Wshadow -Wno-unknown-pragmas -Wsign-compare -ftemplate-backtrace-limit=100 -Werror -std=c++17 -MD -MT src/CMakeFiles/vt.dir/Unity/unity_20_cxx.cxx.o -MF src/CMakeFiles/vt.dir/Unity/unity_20_cxx.cxx.o.d -o src/CMakeFiles/vt.dir/Unity/unity_20_cxx.cxx.o -c /build/vt/src/CMakeFiles/vt.dir/Unity/unity_20_cxx.cxx
In file included from /vt/src/vt/vrt/collection/balance/node_lb_data.h:57,
                 from /vt/src/vt/vrt/collection/manager.impl.h:69,
                 from /vt/src/vt/vrt/collection/manager.h:1773,
                 from /vt/src/vt/scheduler/scheduler.cc:49,
                 from /build/vt/src/CMakeFiles/vt.dir/Unity/unity_20_cxx.cxx:7:
/vt/src/vt/vrt/collection/balance/lb_data_holder.h:52:12: fatal error: vt-tv/api/info.h: No such file or directory
   52 | #  include <vt-tv/api/info.h>
      |            ^~~~~~~~~~~~~~~~~~
compilation terminated.

Build log

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

/vt/tests/perf/send_cost.cc(169): warning #177-D: variable "prevNode" was declared but never referenced
    auto const prevNode = (thisNode - 1 + num_nodes_) % num_nodes_;
               ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 25361b6 (2024-09-17 19:30:11 UTC)

remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhi%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

cwschilly · 2024-07-11T15:07:54Z

If VT_TV_ENABLED is ON, all tests will be run with --vt_tv and the default config file, test_vttv.yaml. This will not generate any pngs or meshes--it only tests that the data is passed from vt to vt-tv without any errors.

cwschilly · 2024-07-18T13:33:06Z

The vt-tv pipeline shows this error when trying to access the cached docker image:

#6 [ubuntu-cpp-vtk] importing cache manifest from ***/vt:amd64-ubuntu-22.04-gcc-12-gcc-12-vtk-cpp
#6 ERROR: failed to configure registry cache importer: docker.io/***/vt:amd64-ubuntu-22.04-gcc-12-gcc-12-vtk-cpp: not found

I think this will be resolved once we push to develop and the pushdockerimage.yml workflow runs. Is that correct?

src/vt/vrt/collection/balance/lb_data_holder.cc

…al function

pierrepebay self-assigned this May 28, 2024

pierrepebay linked an issue May 28, 2024 that may be closed by this pull request

Integrate vt-tv API into LB data export #2174

Closed

1 task

This was referenced Jun 18, 2024

Fix vt-tv bugs to work with vt data DARMA-tasking/LB-analysis-framework#518

Closed

Fix vt-tv bugs to work with vt data DARMA-tasking/vt-tv#78

Closed

pierrepebay force-pushed the 2174-integrate-vt-tv-api-into-lb-data-export-new branch from 469a125 to b617aa1 Compare July 8, 2024 14:52

cwschilly force-pushed the 2174-integrate-vt-tv-api-into-lb-data-export-new branch from 59eb311 to e2fc3f1 Compare July 10, 2024 17:35

cwschilly marked this pull request as ready for review July 11, 2024 18:21

cwschilly force-pushed the 2174-integrate-vt-tv-api-into-lb-data-export-new branch from cf09f54 to 078a157 Compare July 11, 2024 18:26

cwschilly marked this pull request as draft July 11, 2024 19:32

cwschilly mentioned this pull request Jul 16, 2024

Resolve build warnings DARMA-tasking/vt-tv#86

Closed

cwschilly force-pushed the 2174-integrate-vt-tv-api-into-lb-data-export-new branch from 4835965 to d4c7942 Compare July 17, 2024 21:07

cwschilly self-assigned this Jul 18, 2024

cwschilly force-pushed the 2174-integrate-vt-tv-api-into-lb-data-export-new branch from 68399a6 to b639c00 Compare July 18, 2024 13:53

cwschilly marked this pull request as ready for review July 18, 2024 13:53

This was referenced Jul 18, 2024

#89: Use same QOI variant type as vt DARMA-tasking/vt-tv#90

Merged

#88: Guard against multiple yaml-cpp installs DARMA-tasking/vt-tv#91

Merged

cwschilly force-pushed the 2174-integrate-vt-tv-api-into-lb-data-export-new branch from b639c00 to d53f645 Compare July 23, 2024 18:21

cwschilly requested review from stmcgovern, lifflander, cz4rs, thearusable, JacobDomagala, ppebay and nlslatt July 24, 2024 13:05

cwschilly force-pushed the 2174-integrate-vt-tv-api-into-lb-data-export-new branch from d53f645 to 7a37e55 Compare August 1, 2024 14:05

JacobDomagala reviewed Aug 1, 2024

View reviewed changes

src/vt/vrt/collection/balance/lb_data_holder.cc Outdated Show resolved Hide resolved

JacobDomagala reviewed Aug 1, 2024

View reviewed changes

src/vt/vrt/collection/balance/lb_data_holder.cc Outdated Show resolved Hide resolved

cwschilly added 27 commits September 17, 2024 15:30

#2174: improve cmake and add testing for vttv when enabled

ac40092

#2174: update vttv azure pipeline

9399be3

#2174: remove vtk dir from cmake variables

8bae069

#2174: remove vtk_dir from azure configs

ccfa0cd

#2174: run vttv pipeline in draft (temporarily)

a31ec65

#2174: try dockerfile fix

1d2e7d1

#2174: rework vt_tv_enabled logic

fbba728

#2174: try different comparison in dockerfile

f9b6256

#2174: add new dockerfile with vtk build

1ef1b00

#2174: update vttv workflow

418cbf2

#2174: don't remove vtk source directory after building

56e78ba

#2174: disable trace_only build on vttv pipeline

52ae4e3

#2174: only run vttv pipeline when PR is ready for review

785dd18

#2174: add vt-tv params to yaml options

0578600

#2174: small bug fixes

5a738a6

#2174: update clang-16 workflow with vttv option

41c472f

#2174: small improvements

5b7fae9

#2174: restore original operator+ function signature

ad76c21

#2174: add lib/vt-tv to .gitignore

7bc6d6f

#2174: restore cmakelists to original order

ac7dec5

#2174: remove CMAKE_POSITION_INDEPENDENT_CODE and create gatherTVGlob…

659348e

…al function

#2174: load local packages after bundled libraries

6e8abcf

#2174: remove unneeded output field from vttv config

e72cb28

#2174: update azure pipelines after rebase

94782d1

#2174: delete vtk source directory after building; do not install vtk

ef4b213

#2174: use vtk install dir instead of build dir

7d63592

#2174: target 1.5.0 tag for vt-tv build

25361b6

cwschilly force-pushed the 2174-integrate-vt-tv-api-into-lb-data-export-new branch from c11854b to 25361b6 Compare September 17, 2024 19:40

lifflander approved these changes Sep 17, 2024

View reviewed changes

lifflander merged commit 5f21d4c into develop Sep 19, 2024
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2174: Integrate vt-tv api into lb data export #2294

#2174: Integrate vt-tv api into lb data export #2294

pierrepebay commented May 28, 2024

github-actions bot commented May 28, 2024 •

edited

Loading

cwschilly commented Jul 11, 2024 •

edited

Loading

cwschilly commented Jul 18, 2024

#2174: Integrate vt-tv api into lb data export #2294

#2174: Integrate vt-tv api into lb data export #2294

Conversation

pierrepebay commented May 28, 2024

github-actions bot commented May 28, 2024 • edited Loading

Pipelines results

cwschilly commented Jul 11, 2024 • edited Loading

cwschilly commented Jul 18, 2024

github-actions bot commented May 28, 2024 •

edited

Loading

cwschilly commented Jul 11, 2024 •

edited

Loading