#2240: Add Rabenseifner and Recursive doubling allreduce algorithms for ObjGroup
#2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipelines resultsPR tests (gcc-12, ubuntu, mpich) Build for 16da9e7 (2024-04-16 12:06:29 UTC) PR tests (gcc-12, ubuntu, mpich, verbose) Build for 5ce7cd9 (2024-06-18 16:35:02 UTC) PR tests (gcc-12, ubuntu, mpich, verbose, kokkos) Build for 57b8cab (2024-07-18 15:27:27 UTC) |
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
2 times, most recently
from
17cfcbd
to
16da9e7
Compare
|
Results of running allreduce on std::vector<int32_t> with 65536 elements |
|
Results of running allreduce on std::vector<int32_t> with 2 elems |
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
2 times, most recently
from
53da893
to
e3fa49b
Compare
|
Still missing:
|
ppebay
changed the title
Rabenseifner and Recursive doubling allreduce algorithms for ObjGroupRabenseifner and Recursive doubling allreduce algorithms for ObjGroup
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
2 times, most recently
from
80d6712
to
f01bad5
Compare
|
Regarding the issue with the If users want to use their custom wrapper, then they should provide #include <vector>
#ifdef VT_KOKKOS_ENABLED
#include <Kokkos_Core.hpp>
#endif
template <typename Container>
class DataHandler {
public:
using Scalar = float;
static size_t size(const Container& data);
static Scalar& at(Container& data, size_t idx);
static void set(Container& data, size_t idx, const Scalar& value);
static Container split(Container& data, size_t start, size_t end);
};
template <typename T>
class DataHandler<std::vector<T>> {
public:
using Scalar = T;
static size_t size(const std::vector<T>& data) { return data.size(); }
static T at(const std::vector<T>& data, size_t idx) { return data[idx]; }
static T& at(std::vector<T>& data, size_t idx) { return data[idx]; }
static void set(std::vector<T>& data, size_t idx, const T& value) {
data[idx] = value;
}
static std::vector<T> split(std::vector<T>& data, size_t start, size_t end) {
return std::vector<T>{data.begin() + start, data.begin() + end};
}
};
#ifdef VT_KOKKOS_ENABLED
template <typename T, typename... Props>
class DataHandler<Kokkos::View<T*, Props...>> {
public:
static size_t size(const Kokkos::View<T*, Props...>& data) {
return data.extent(0);
}
static T at(const Kokkos::View<T*, Props...>& data, size_t idx) {
return data(idx);
}
static T& at(Kokkos::View<T*, Props...>& data, size_t idx) {
return data(idx);
}
static void
set(Kokkos::View<T*, Props...>& data, size_t idx, const T& value) {
data(idx) = value;
}
};
#endif // VT_KOKKOS_ENABLED |
|
Let's go with the |
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
5 times, most recently
from
081570b
to
84e8f72
Compare
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
from
84e8f72
to
34615ad
Compare
lifflander
reviewed
Jun 11, 2024
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
2 times, most recently
from
5ce7cd9
to
168f39a
Compare
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
from
b354603
to
5441ffc
Compare
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
3 times, most recently
from
5c4fed6
to
eafa364
Compare
…I for various data types
…nd fix compile issues realted to using Kokkos::View for allreduce
…ssing proxy by reference
… when user's payload is View
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
from
eafa364
to
f5e685b
Compare
JacobDomagala
force-pushed
the
2240-use-a-proper-all-reduce-algorithm-for-proxyallreduce
branch
from
f5e685b
to
57b8cab
Compare
|
Closing this PR as #2337 contains updated code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2240