Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2172: async_op: update AsyncOpCUDA to just query stream by default #2173

Merged
merged 2 commits into from
Jul 11, 2023
Merged

#2172: async_op: update AsyncOpCUDA to just query stream by default #2173

merged 2 commits into from
Jul 11, 2023

Conversation

lifflander
Copy link
Collaborator

Fixes #2172

@lifflander lifflander linked an issue Jul 10, 2023 that may be closed by this pull request
Update AsyncOpCUDA to using stream query by default #2172
Closed
3 tasks
nlslatt
nlslatt approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

Pipelines results

PR tests (clang-9, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 94883b2 (2023-07-11 17:52:24 UTC)

Compilation - successful

Testing - passed

Build log

nlslatt
nlslatt reviewed Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix required

src/vt/messaging/async_op_cuda.h Outdated Show resolved Hide resolved
@lifflander lifflander merged commit 23bb0a9 into develop Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt nlslatt approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update AsyncOpCUDA to using stream query by default
3 participants
@lifflander @PhilMiller @nlslatt