-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Validators #62
base: main
Are you sure you want to change the base?
Conversation
332fd54
to
9f4fc3c
Compare
Thoughts:
Re: (1) I think we can add an extra field later for this (or add a subfield for check name) but otherwise I'm pretty happy with this. The tricky part is that checks don't have identifiable names... |
9f4fc3c
to
87f15d5
Compare
@@ -137,7 +137,7 @@ it executes on every column that's extracted. | |||
## Handling the results | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file needs to be merged into the main docs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same with basics.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep was waiting for the docs rewrite -- was planning to chop this commit then copy/paste.
This allows us to configure validation on the per-node level. Done at config-time, this sets us up to determine how to add a validator from passed in configuration.
4f4b647
to
64fecf2
Compare
This works both globally and locally. Currently its only at the node level, but it shouldn't be to hard to disable specific validators/set warnings on them.
Node-specific should go *before* global overrides. This fixes it.
64fecf2
to
ba48582
Compare
Ok, I'm going to think through this API this weekend -- feel more confident about the others so i might hold off on this for a bit |
This allows us to configure validation on the per-node level. Done at config-time, this sets us up to determine how to add a validator from passed in configuration.
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist