-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoPandas ShapeFile, Feather, and Parquet Reader and Writer #504
base: main
Are you sure you want to change the base?
Conversation
…, Tests for that class, and additional requirements
Apply Sweep Rules to your PR?
|
Tests are still failing for python 3.7. The earliest version of geodatasets is 0.1.0 (where the example datasets are collected) requires python version 3.8. |
yeah you can gate this with the Otherwise some dataclass issue with the current tests failing? Can't see anything obvious on first glance. |
….py and test_geopandas_extensions.py
@JoJo10Smith BTW we removed support for 3.7 -- so no need to special case anything for that. |
WIP: Adding the GeoPandas FIle Read and Write Class to Hamilton.
Changes
geopandas_extensions.py
--> Adding the read and write classrequirements-test.txt
-> Adding additional requirements that are needed for the classes to worktest_geopandas_extensions.py
--> Adding test for each of the files that are outputtedh_geopandas.py
--> Added this file so that I could create DAGs with Geopandas functionsnotebook.ipynb
--> Examples of usagegeometric_functions.py
--> Examples of usageHow I tested this
Added the classes and showed that they output data in a local notebook. I also wrote a single test to check that all the geodataframses that are outputted (dbf, shp, shx) which are all the memory files are the same as the original example file I used.
more info: https://en.wikipedia.org/wiki/Shapefile
Notes
The output dag in the examples is pictured below
Checklist