Added variable-length contract address support #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSaso
force-pushed
the
noah/variable-contract-addr-len
branch
2 times, most recently
from
7304d5e to
dce1fdb
Compare
NoahSaso
force-pushed
the
noah/variable-contract-addr-len
branch
from
dce1fdb to
c646f34
Compare
NoahSaso
force-pushed
the
noah/variable-contract-addr-len
branch
from
c958048 to
669b353
Compare
NoahSaso
force-pushed
the
noah/variable-contract-addr-len
branch
from
669b353 to
a71be1f
Compare
JakeHartnell
approved these changes
May 28, 2024
Reecepbcups
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
This adds the ability to specify the contract address length used by the chain when instantiating the voice contract. This is required because some chains (such as Injective) use non-standard contract address lengths. Typically they are 32, but Injective uses 20.
This also adds a query to fetch the sender information from the voice given a proxy address.