Adds support for parsing doc comments on Rust types #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
Not stale, still waiting for review |
|
sorry for the delayed reviewing, please wait a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the already existing support for parsing comments on functions/methods by using the same logic for the C# generating type-bindings.
Also fixes a bunch of misc. Clippy warnings, but nothing functionality-changing.
As a note: I think this has the potential to make the generated C# bindings quite "noisy" in the sense that a ton of comments can be generated. I personally think that that's a good thing, but maybe it would be worth it to put comment generation behind a flag? Let me know what you think, I could put that in as a feature later if desired.