fix handling of MaybeUninit #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current csbindgen, type
MaybeUninit<some_type>will be converted toMaybeUniniton the binding code. This behaviour makes the output code unusable because the information about the internal type is missing.I modified the parser code to just ignore MaybeUninit<> and just use the internal type.
I'm not expert of Rust but I think it is ok, as MaybeUninit is for indicating that the memory is not initialized, I guess it can be ignored on binding code.
For reference, here's one of the code which uses MaybeUninit<>.
https://github.com/eclipse-zenoh/zenoh-c/blob/1010f5b6544f476a34046420a7a561e754ce6cbd/src/session.rs#L82-L86