Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Benchmark Adopt to .NET 9 #875

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: Benchmark Adopt to .NET 9 #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/PerformanceTest.Client/PerformanceTest.Client.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<DefineConstants>CLIENT;$(DefineConstants)</DefineConstants>
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/PerformanceTest.Server/PerformanceTest.Server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<DefineConstants>SERVER;$(DefineConstants)</DefineConstants>
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/PerformanceTest.Shared/PerformanceTest.Shared.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
27 changes: 25 additions & 2 deletions perf/BenchmarkApp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,28 @@ $ dotnet run -c Release -- -u http://localhost:5000 -s unary --report report.txt

#### Use Repository-local MagicOnion.Client (`dotnet` command option)
```
$ dotnet run -c Release -p:UseRepositoryClient=true -- -u http://localhost:5000 -s unary
```
$ dotnet run -c Release -p:UseRepositoryClient=true -- -u http://localhost:5000 -s unary
```

## Datadog Event

Post Datadog event if you changed TargetFramework.

```shell
curl -X POST "https://api.datadoghq.com/api/v1/events" \
-H "Accept: application/json" \
-H "Content-Type: application/json" \
-H "DD-API-KEY: ${DD_API_KEY}" \
-H "DD-APPLICATION-KEY: ${DD_APP_KEY}" \
-d @- << EOF
{
"tags": [
"type:benchmark",
"app:magiconion",
"changed:target-framework"
],
"title": "magiconion target framework updated",
"text": "magiconion target framework version has been updated from 8.0 to 9.0"
}
EOF
```
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/issue.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/schedule_ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: "libmsquic"
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
#benchmark-location: "japaneast"
benchmark-location: "eastus"
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/schedule_serverstreaming.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: "libmsquic"
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
#benchmark-location: "japaneast"
benchmark-location: "eastus"
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_memorypack_h2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_memorypack_h2c.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_memorypack_h3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: "libmsquic"
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h2_nugetclient.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h2_nugetserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h2c.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h2c_eastus.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "eastus"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h2c_nugetclient.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h2c_nugetserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h2c_serverstreaming.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: "libmsquic"
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h3_nugetclient.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
2 changes: 1 addition & 1 deletion perf/BenchmarkApp/configs/workflow_dispatch_messagepack_h3_nugetserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# template: https://github.com/Cysharp/Actions/tree/main/.github/scripts/_template_benchmark_config.yaml
# config2args script: https://github.com/Cysharp/Actions/tree/main/.github/scripts/benchmark_config2args.sh
apt-tools: ""
dotnet-version: 8.0
dotnet-version: 9.0
benchmark-expire-min: 15
benchmark-location: "japaneast"
benchmark-timeout-min: 10
Expand Down
Loading