This repository has been archived by the owner on Apr 20, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Decoupling improvements #5
Open
tiagoalves
wants to merge
22
commits into
master
Choose a base branch
from
feature/decoupling-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Laravel 5.1 Branch is not intended to merge, but rather to reserve a lane for those 5.1 projects that are not ready yet to move to 5.2
Does not exist in 5.1
Devs can now provide their own job dispatcher implementation. Devs can now provide their own user model implementation. Added indexes to the `oauth_access_tokens` table.
Now, base apps can provide their own logic to create a user representation object with the fields that this module's views require.
Now we can return error messages with the usual UI styling of this package.
…uirements. * The User model and api->blm job dispatcher can now be provided by the base Laravel app. * Package-specific exception handler so we can transform exceptions into errors that are shown in the login view instead of dumping a stack trace in the browser. * * Added indexes to the `oauth_access_tokens` table for faster lookups.
Now the module uses its own User trait as well.
Change introduced in 99af026. This branch is for Laravel 5.2+, that's why I'm removing the Laravel 5.1 related change that was merged into this branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Laravel 5.1 compatibility branch (
lvl51
) has introduced several decoupling improvements which facilitate the usage of this module by third-party Laravel applications.These include:
User
as long as it includes this module's providedUserTrait
.This PR migrates these improvements to the master branch where we maintain the Laravel 5.2+ compatibility.