Merge pull request #617 from Cypherock/feat/starknet/refactored/sign-txn

Cypherock · Jan 8, 2025 · 44a4e78 · 44a4e78
2 parents bf7396f + d99c888
commit 44a4e78
Show file tree

Hide file tree

Showing 21 changed files with 1,574 additions and 14 deletions.
diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml
@@ -88,7 +88,7 @@ jobs:
       fail-fast: false
       matrix:
         firmware: [main]
-        target: [release, dev]
+        target: [release]
         platform: [device, simulator]
     runs-on: ubuntu-latest
 

diff --git a/.gitmodules b/.gitmodules
@@ -10,3 +10,6 @@
 [submodule "mini-gmp"]
 	path = vendor/mini-gmp
 	url = ../mini-gmp
+[submodule "poseidon"]
+	path = vendor/poseidon
+	url = ../poseidon
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -27,6 +27,7 @@ file(GLOB_RECURSE PROTO_SRCS "generated/proto/*.*")
 list(APPEND PROTO_SRCS "vendor/nanopb/pb_common.c" "vendor/nanopb/pb_decode.c" "vendor/nanopb/pb_encode.c" "vendor/nanopb/pb_common.h" "vendor/nanopb/pb_decode.h" "vendor/nanopb/pb_encode.h" "vendor/nanopb/pb.h")
 
 list (APPEND MINI_GMP_SRCS "vendor/mini-gmp/mini-gmp-helpers.c" "vendor/mini-gmp/mini-gmp.c")
+list (APPEND POSEIDON_SRCS "vendor/poseidon/sources/f251.c" "vendor/poseidon/sources/poseidon.c" "vendor/poseidon/sources/poseidon_rc.c")
 
 OPTION(DEV_SWITCH "Additional features/logs to aid developers" OFF)
 OPTION(UNIT_TESTS_SWITCH "Compile build for main firmware or unit tests" OFF)
@@ -51,7 +52,7 @@ else()
 endif()
 
 # Include nanopb source headers
-target_include_directories( ${EXECUTABLE} PRIVATE vendor/nanopb generated/proto vendor/mini-gmp)
+target_include_directories( ${EXECUTABLE} PRIVATE vendor/nanopb generated/proto vendor/mini-gmp vendor/poseidon/sources)
 
 # Enable support for dynamically allocated fields in nanopb
 # Ref: vendor/nanopb/pb.h

diff --git a/apps/starknet_app/starknet_context.h b/apps/starknet_app/starknet_context.h
@@ -32,6 +32,8 @@
 /// this makes length of 5 with a termination NULL byte
 #define STARKNET_LONG_NAME_MAX_SIZE 9
 
+#define STARKNET_BIGNUM_SIZE 32
+
 /*****************************************************************************
  * TYPEDEFS
  *****************************************************************************/

diff --git a/apps/starknet_app/starknet_main.c b/apps/starknet_app/starknet_main.c
@@ -129,7 +129,7 @@ void starknet_main(usb_event_t usb_evt, const void *app_config) {
       break;
     }
     case STARKNET_QUERY_SIGN_TXN_TAG: {
-      // starknet_sign_transaction(&query);
+      starknet_sign_transaction(&query);
       break;
     }
 

diff --git a/apps/starknet_app/starknet_pedersen.c b/apps/starknet_app/starknet_pedersen.c
@@ -67,6 +67,7 @@
 
 #include "coin_utils.h"
 #include "mini-gmp-helpers.h"
+#include "starknet_context.h"
 #include "starknet_helpers.h"
 
 /*****************************************************************************

diff --git a/apps/starknet_app/starknet_pedersen.h b/apps/starknet_app/starknet_pedersen.h
@@ -64,6 +64,7 @@
 #include <stdint.h>
 
 #include "mpz_pedersen.h"
+#include "starknet_context.h"
 
 /*****************************************************************************
  * EXTERN VARIABLES
@@ -76,8 +77,6 @@
 #define LOW_PART_BYTES (LOW_PART_BITS / 8)
 #define LOW_PART_MASK ((1ULL << LOW_PART_BITS) - 1)
 
-#define STARKNET_BIGNUM_SIZE                                                   \
-  32    ///< Max byte size of a bignum in starknet context
 #define PEDERSEN_HASH_SIZE 32
 
 #define CALL_DATA_PARAMETER_SIZE 3
-Original file line number
+Diff line change
@@ Expand Up @@
           break;
         }
         case STARKNET_QUERY_SIGN_TXN_TAG: {
-          // starknet_sign_transaction(&query);
+          starknet_sign_transaction(&query);
           break;
         }
@@ Expand Down @@