improvements

add log support
fix config loading
fix step placeholder in parameter editor

.changeset/two-flies-film.md

@@ -0,0 +1,8 @@
+---
+'@pipelab/app': patch
+---
+
+improvements
+add log support
+fix config loading
+fix step placeholder in parameter editor

TODO

@@ -43,13 +43,13 @@ https://remixicon.com/
 ---
 
 Tests:
-- View logs in realtime
-- env (= copy variables)
-- handle pipeline error gracefully
-    - display what happened in dialog
-- handle steamworks
-
-- prepare electron + install package
-- process quickjs in webworker
+☐ View logs in realtime: started
+☐ env (= copy variables)
+☐ handle pipeline error gracefully
+    ☐ display what happened in dialog
+☐ handle steamworks
+
+☐ prepare electron + install package
+☐ process quickjs in webworker
 
 

src/main/handler-func.ts

@@ -17,6 +17,7 @@ import { useLogger } from '@@/logger'
 import { BrowserWindow } from 'electron'
 import { usePluginAPI } from './api'
 import { BlockCondition } from '@@/model'
+import { HandleListenerSendFn } from './handlers'
 
 const checkParams = (definitionParams: InputsDefinition, elementParams: Record<string, string>) => {
   // get a list of all required params
@@ -46,7 +47,7 @@ const checkParams = (definitionParams: InputsDefinition, elementParams: Record<s
 export const handleConditionExecute = async (
   nodeId: string,
   pluginId: string,
-  params: BlockCondition['params'],
+  params: BlockCondition['params']
   // { send }: { send: HandleListenerSendFn<'condition:execute'> }
 ): Promise<End<'condition:execute'>> => {
   const { plugins } = usePlugins()
@@ -116,7 +117,7 @@ export const handleActionExecute = async (
   pluginId: string,
   params: Record<string, string>,
   mainWindow: BrowserWindow | undefined,
-  // { send }: { send: HandleListenerSendFn<'action:execute'> }
+  send: HandleListenerSendFn<'action:execute'>
 ): Promise<End<'action:execute'>> => {
   const { plugins } = usePlugins()
   const { logger } = useLogger()
@@ -160,7 +161,12 @@ export const handleActionExecute = async (
       await node.runner({
         inputs: resolvedInputs,
         log: (...args) => {
-          logger().info(`[${node.node.name}]`, ...args)
+          const logArgs = [`[${node.node.name}]`, ...args]
+          logger().info(...logArgs)
+          send({
+            type: 'log',
+            data: logArgs
+          })
         },
         setOutput: (key, value) => {
           outputs[key] = value

src/main/handlers.ts

@@ -140,6 +140,9 @@ export const registerIPCHandlers = () => {
 
     const { canceled, filePath } = await dialog.showSaveDialog(mainWindow, value)
 
+    console.log('canceled', canceled)
+    console.log('filePath', filePath)
+
     send({
       type: 'end',
       data: {
@@ -207,7 +210,7 @@ export const registerIPCHandlers = () => {
 
     const mainWindow = BrowserWindow.fromWebContents(event.sender)
 
-    const result = await handleActionExecute(nodeId, pluginId, params, mainWindow)
+    const result = await handleActionExecute(nodeId, pluginId, params, mainWindow, send)
 
     await send({
       data: result,
@@ -231,13 +234,30 @@ export const registerIPCHandlers = () => {
     })
   })
 
+  const ensure = async (filesPath: string) => {
+    // create parent folder
+    await mkdir(dirname(filesPath), {
+      recursive: true
+    })
+
+    // ensure file exist
+    try {
+      await access(filesPath)
+    } catch {
+      // File doesn't exist, create it
+      await writeFile(filesPath, '{}') // json
+    }
+  }
+
   handle('config:load', async (_, { send, value }) => {
     const { config } = value
 
     const userData = app.getPath('userData')
 
     const filesPath = join(userData, 'config', config + '.json')
 
+    await ensure(filesPath)
+
     let content = '{}'
     try {
       content = await readFile(filesPath, 'utf8')
@@ -265,18 +285,7 @@ export const registerIPCHandlers = () => {
 
     const filesPath = join(userData, 'config', config + '.json')
 
-    // create parent folder
-    await mkdir(dirname(filesPath), {
-      recursive: true
-    })
-
-    // ensure file exist
-    try {
-      await access(filesPath)
-    } catch {
-      // File doesn't exist, create it
-      await writeFile(filesPath, '{}') // json
-    }
+    await ensure(filesPath)
 
     await writeFile(filesPath, data, 'utf8')