Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for ControlNodes aka non-system, non-patcher nodes #79

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

fde31
Copy link
Member

@fde31 fde31 commented Mar 8, 2024

closes #70

@fde31 fde31 requested a review from x37v March 8, 2024 16:30
@x37v
Copy link
Contributor

x37v commented Mar 8, 2024

one note @fde31
this doesn't dynamically update when you add a new jack client, you can test this by doing this:

  • start the web UI and target your pi
  • ssh to your pi
  • run jack_midi_dump
    • you may have to sudo apt-get install jack-tools before

you should see midi-monitor now in the graph but you don't until you reload the page

@fde31
Copy link
Member Author

fde31 commented Mar 14, 2024

ok should be addressed now. Want to test it once more @x37v ?

Copy link
Contributor

@x37v x37v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working great!

@fde31 fde31 merged commit 7322bca into develop Mar 14, 2024
1 check passed
@fde31 fde31 deleted the fde/control_nodes branch March 14, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: render non-system non-rnbo nodes
2 participants