More tooltips #158
Merged
More tooltips #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x37v
reviewed
Jun 25, 2024
src/components/datafile/item.tsx
Outdated
Comment on lines
20
to
30
| title: "Delete Sample Dependency", | ||
| centered: true, | ||
| children: ( | ||
| <Text size="sm"> | ||
| Are you sure you want to delete the sample dependency { `"${dataFile.fileName}"` } from the runner? | ||
| </Text> | ||
| ), | ||
| labels: { confirm: "Delete", cancel: "Cancel" }, | ||
| confirmProps: { color: "red" }, | ||
| onConfirm: () => onDelete(dataFile) | ||
| }); |
There was a problem hiding this comment.
I think we should rename Sample Dependency to something else.. Audio File ?
Both here and in the left menu to get to the sample dep page.
They're not actually "Dependencies".. they are simply files that can be applied to a buffer (aka dataref) mapping.
…button with label depending on screen size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces more tooltips across the whole UI, adjusts the help link to go straight to the Web Interface page and uses a diff icon for patcher instance unloading.