Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance "degraded" status #57

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

brknkfr
Copy link
Contributor

@brknkfr brknkfr commented Oct 23, 2023

Notes

status.sh:

  • Added MY_HOSTNAME_STATUS_DEGRADE for "degraded" services
  • Added MY_HOSTNAME_STATUS_LASTRUN_DEGRADE for calculating "degraded" time of services
  • Fixed naming of MY_DEGRADE_COUNT (was MY_OUTAGEDEGRADE_COUNT)
  • Fixed some typos

alert.sh:

  • Added MY_HOSTNAME_STATUS_DEGRADE for "degraded" services
  • Added logic for services which are first "degraded" and then are changing to "down"
  • Simplifed logic for adding entries to MY_HOSTNAME_STATUS and MY_HOSTNAME_STATUS_DEGRADE (only write or delete them once, not on every notification)

config-example:

  • Added MY_HOSTNAME_STATUS_DEGRADE parameter for file with "degraded" services

@brknkfr brknkfr force-pushed the fix_degrade_status branch 2 times, most recently from c47588e to 841f079 Compare October 23, 2023 15:53
@Cyclenerd
Copy link
Owner

Hi, thanks for the pull. Please describe your change in more detail. What exactly is being fixed? Was there an error? What improvement comes with this modification? Why did you removed the "Powered by"?

- Added MY_HOSTNAME_STATUS_DEGRADE for "degraded" services
- Added MY_HOSTNAME_STATUS_LASTRUN_DEGRADE for calculating "degraded" time of services
- Fixed naming of MY_DEGRADE_COUNT (was MY_OUTAGEDEGRADE_COUNT)
- Fixed some typos

alert.sh:
- Added MY_HOSTNAME_STATUS_DEGRADE for "degraded" services
- Added logic for services which are first "degraded" and then are changing to "down"
- Simplifed logic for adding entries to MY_HOSTNAME_STATUS and MY_HOSTNAME_STATUS_DEGRADE (only write or delete them once, not on every notification)

config-example:
- Added MY_HOSTNAME_STATUS_DEGRADE parameter for file with "degraded" services
@brknkfr brknkfr force-pushed the fix_degrade_status branch from 841f079 to 0be7235 Compare October 23, 2023 18:16
@brknkfr
Copy link
Contributor Author

brknkfr commented Oct 23, 2023

What exactly is being fixed? Was there an error?

The parameters were named wrongly, see commit message. It didn't calculate correctly the time.

What improvement comes with this modification?

You can now trigger a notification when there is a degraded service which wasn't possible before.

Why did you removed the "Powered by"?

Oh, sorry, I didn't want to! This happend by accident.

Rebuild configuration so that status.sh with old config files continue to work.
Rebuild configuration so that alert.sh with old config files continue to work.
@Cyclenerd Cyclenerd merged commit 3b8f64b into Cyclenerd:master Oct 25, 2023
@Cyclenerd
Copy link
Owner

Thank you 👍

@brknkfr brknkfr deleted the fix_degrade_status branch January 22, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants