Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merchant boarding Sample codes #97

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Merchant boarding Sample codes #97

wants to merge 6 commits into from

Conversation

surnayak1991
Copy link
Contributor

No description provided.

gaubansa
gaubansa reviewed Sep 25, 2024
View reviewed changes
src/main/java/samples/MerchantBoarding/CreateRegistration.java Outdated


public static InlineResponse2012 run() {
System.out.println("Inside Merchant boarding...........");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this comment?

src/main/java/samples/MerchantBoarding/CreateRegistration.java Outdated

reqObj.productInformation(productInformation);

System.out.println("Req obj created...........");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this comment?

src/main/java/samples/MerchantBoarding/CreateRegistration.java Outdated
InlineResponse2012 result=null;

try {
merchantProp = MerchantBoardingConfiguration.getMerchantBoardingDetails();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this getMerchantBoardingDetails() to getMerchantConfigForBoardingAPI()

src/main/java/samples/MerchantBoarding/CreateRegistration.java Outdated
InlineResponse2012 result=null;

try {
merchantProp = MerchantBoardingConfiguration.getMerchantBoardingDetails();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment line here, that "Boarding API support only JWT Auth Type"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaubansa gaubansa gaubansa left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surnayak1991 @gaubansa