Skip to content

Commit

Permalink
Revert "common.bash: Automate pacman prompts more aggressively"
Browse files Browse the repository at this point in the history
This reverts commit cd1c4b0.

Not a universal solution as pacman asks for not just yes-or-no
questions, see e.g.
#143.

Let's park this feature until we have a compelling, test-case-backed
use case for it.  For now, users will need to occasionally run
aconfmgr in interactive mode to confirm prompts that pacman deems
too dangerous for --noconfirm.
  • Loading branch information
CyberShadow committed Mar 29, 2022
1 parent da8b6d6 commit 2004125
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions src/common.bash
Original file line number Diff line number Diff line change
Expand Up @@ -1229,13 +1229,7 @@ function AconfInstallNative() {
fi

local target_packages=("$@")
if [[ $prompt_mode == never ]]
then
# Some prompts default to 'no'
( yes || true ) | sudo "${pacman_opts[@]}" --confirm --sync "${asdeps_arr[@]}" "${target_packages[@]}"
else
sudo "${pacman_opts[@]}" --sync "${asdeps_arr[@]}" "${target_packages[@]}"
fi
sudo "${pacman_opts[@]}" --sync "${asdeps_arr[@]}" "${target_packages[@]}"
}

function AconfInstallForeign() {
Expand Down

0 comments on commit 2004125

Please sign in to comment.