Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book/architecture: RPC handlers and related #341

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hinto-janai
Copy link
Contributor

What

Fills RPC sections in the architecture book to cover the changed made in #244.

@github-actions github-actions bot added the A-workspace Changes to a root workspace file or general repo file. label Nov 15, 2024
@hinto-janai hinto-janai mentioned this pull request Nov 15, 2024
12 tasks
@github-actions github-actions bot added A-docs Related to documentation. A-rpc Related to RPC. A-books Related to Cuprate's books. A-book-architecture Related to the Architecture book. labels Dec 25, 2024
The handlers (functions that map requests into responses) are / can be generic with `cuprate-rpc-interface`.

The main handlers used by Cuprate is implemented in `cuprated` itself, it implements the standard RPC handlers modeled after `monerod`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The main handlers used by Cuprate is implemented in `cuprated` itself, it implements the standard RPC handlers modeled after `monerod`.
The main handlers used by Cuprate are implemented in `cuprated` itself, it implements the standard RPC handlers modeled after `monerod`.

The main handlers used by Cuprate is implemented in `cuprated` itself, it implements the standard RPC handlers modeled after `monerod`.

- JSON-RPC handlers: <LINK_TO_FILE>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- JSON-RPC handlers: <LINK_TO_FILE>
- JSON-RPC handlers: <LINK_TO_FILE>

lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links do not exist yet, they depend on #355.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-book-architecture Related to the Architecture book. A-books Related to Cuprate's books. A-docs Related to documentation. A-rpc Related to RPC. A-workspace Changes to a root workspace file or general repo file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants