Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terrorist and Soldier AI Update #430

Closed
wants to merge 13 commits into from
Closed

Terrorist and Soldier AI Update #430

wants to merge 13 commits into from

Conversation

strubium
Copy link
Contributor

@strubium strubium commented May 7, 2024

📝 Description

Improves the Terrorist and Soldier AI, making them more fun to fight

🎯 Goals

  • Remove the zillion explicit casts to EntityCreature cause it was confusing me
  • Improve the AI in combat.

❌ Non Goals

  • Fix bugs about Grenades
  • New behavior (Later, firerate could be controlled by whatever gun they are using)

🚦 Testing

I have not tested this yet

⏮️ Backwards Compatibility

1.12.2

📚 Related Issues & Documents

#428

🖼️ Screenshots/Recordings

n/a (yet)

📖 Added to documentation?

  • 📜 README.md
  • 📑 Documentation
  • 📓 Javadoc
  • 🍕 Comments
  • 🙅 No documentation needed

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 7, 2024

Important

Auto Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Desoroxxx
Desoroxxx requested changes May 7, 2024
View reviewed changes
src/main/java/com/paneedah/mwc/entities/Entities.java Outdated Show resolved Hide resolved
src/main/java/com/paneedah/mwc/entities/Entities.java
.withPrimaryEquipmentDropChance(0.4f)
.withSpawn(10, 0, 15, BiomeDictionary.Type.PLAINS, BiomeDictionary.Type.HILLS)
.withMaxAmmo(1000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI should not have max ammunition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI already has max ammunition, by default is it 36000

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI already has max ammunition, by default is it 36000

Which is vitrually infinite since they shoot about once every second.
Anyway irrelevant, I did not make this, but they should have infinite ammunition, they shouldn't check against a max ammount, they should just shoot if they desire so.

src/main/java/com/paneedah/mwc/entities/Entities.java
@@ -39,49 +42,55 @@ public static void init(CommonProxy commonProxy) {
.withTexturedModelVariant("com.paneedah.mwc.models.BanditNew5", "banditnew5.png")
.withHurtSound("hurt")
.withAmbientSound("drawweapon")
// .withStepSound("step")
.withStepSound("step")
.withLookHeightMulitplier(3)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #428

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #428

Still what?

src/main/java/com/paneedah/mwc/entities/Entities.java Outdated Show resolved Hide resolved
src/main/java/com/paneedah/mwc/entities/Entities.java
.withPrimaryEquipmentDropChance(0.4f)
.withMaxAmmo(1500)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI should not have max ammunition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI already has max ammunition, by default is it 36000

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI already has max ammunition, by default is it 36000

Which is vitrually infinite since they shoot about once every second.
Anyway irrelevant, I did not make this, but they should have infinite ammunition, they shouldn't check against a max ammount, they should just shoot if they desire so.

src/main/java/com/paneedah/mwc/entities/Entities.java
@@ -90,39 +99,39 @@ public static void init(CommonProxy commonProxy) {
.withTexturedModelVariant("com.paneedah.mwc.models.SoldierSniper", "soldiersniper.png")
.withHurtSound("hurt")
.withAmbientSound("drawweapon")
// .withStepSound("step")
.withStepSound("step")
.withLookHeightMulitplier(3)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #428

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #428

Still what?

@Desoroxxx
Copy link
Collaborator

The changes needed are just a few important things I noted.

But in general, please note that any changes, especially things like this, should be accompanied by reasoning, just changing things without explaining why isn't great for me to be able to merge it.

Also as indicated on the Trello (for once Trello is up to date lol) a complete rework of the NPC's is coming soon-ish, (although you already know that from the issue lol).

My advice here is probably to wait until the rework is done, then test things and play a bit with the rework, then come back to this.

@strubium
Copy link
Contributor Author

strubium commented May 7, 2024

Cool, Thank you

@strubium strubium closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desoroxxx Desoroxxx Desoroxxx requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strubium @Desoroxxx