Allow conditional notifications

app/defaults.yml

@@ -36,8 +36,9 @@ notifiers:
       webhook: null
     optional:
       template: "{{exchange}}-{{market}}-{{indicator}}-{{indicator_number}} is {{status}}!{{ '\n' -}}"
-  gmail:
+  email:
     required:
+      smtp_server: null
       username: null
       password: null
       destination_emails: null

app/notification.py

@@ -28,7 +28,7 @@
 from analyzers.indicators import candle_recognition, ichimoku
 from analyzers.utils import IndicatorUtils
 from notifiers.discord_client import DiscordNotifier
-from notifiers.gmail_client import GmailNotifier
+from notifiers.email_client import EmailNotifier
 from notifiers.slack_client import SlackNotifier
 from notifiers.stdout_client import StdoutNotifier
 from notifiers.telegram_client import TelegramNotifier
@@ -91,15 +91,16 @@ def __init__(self, notifier_config, indicator_config, conditional_config, market
             )
             enabled_notifiers.append('slack')
 
-        self.gmail_configured = self._validate_required_config(
-            'gmail', notifier_config)
-        if self.gmail_configured:
-            self.gmail_client = GmailNotifier(
-                username=notifier_config['gmail']['required']['username'],
-                password=notifier_config['gmail']['required']['password'],
-                destination_addresses=notifier_config['gmail']['required']['destination_emails']
+        self.email_configured = self._validate_required_config(
+            'email', notifier_config)
+        if self.email_configured:
+            self.email_client = EmailNotifier(
+                smtp_server=notifier_config['email']['required']['smtp_server'],
+                username=notifier_config['email']['required']['username'],
+                password=notifier_config['email']['required']['password'],
+                destination_addresses=notifier_config['email']['required']['destination_emails']
             )
-            enabled_notifiers.append('gmail')
+            enabled_notifiers.append('email')
 
         self.telegram_configured = self._validate_required_config(
             'telegram', notifier_config)
@@ -223,7 +224,7 @@ def notify_all_messages(self, exchange, market_pair, candle_period, messages):
         self.notify_discord(messages)
         self.notify_webhook(messages, chart_file)
         # self.notify_twilio(new_analysis)
-        # self.notify_gmail(new_analysis)
+        self.notify_email(messages)
         self.notify_telegram(messages, chart_file)
         self.notify_stdout(messages)
 
@@ -274,20 +275,21 @@ def notify_twilio(self, new_analysis):
             if message.strip():
                 self.twilio_client.notify(message)
 
-    def notify_gmail(self, new_analysis):
-        """Send a notification via the gmail notifier
+    def notify_email(self, new_analysis):
+        """Send a notification via the email notifier
 
         Args:
             new_analysis (dict): The new_analysis to send.
         """
+        if not self.email_configured:
+            return
 
-        if self.gmail_configured:
-            message = self._indicator_message_templater(
-                new_analysis,
-                self.notifier_config['gmail']['optional']['template']
-            )
-            if message.strip():
-                self.gmail_client.notify(message)
+        message_template = Template(
+            self.notifier_config['email']['optional']['template'])
+
+        for message in new_analysis:
+            formatted_message = message_template.render(message)
+            self.email_client.notify(formatted_message.strip())
 
     def notify_telegram(self, messages, chart_file):
         """Send notifications via the telegram notifier

app/notifiers/gmail_client.py → app/notifiers/email_client.py

@@ -1,4 +1,4 @@
-"""Notify a user via Gmail
+"""Notify a user via Email
 """
 
 import smtplib
@@ -9,21 +9,22 @@
 from notifiers.utils import NotifierUtils
 
 
-class GmailNotifier(NotifierUtils):
-    """Class for handling gmail notifications
+class EmailNotifier(NotifierUtils):
+    """Class for handling email notifications
     """
 
-    def __init__(self, username, password, destination_addresses):
-        """Initialize GmailNotifier class
+    def __init__(self, smtp_server, username, password, destination_addresses):
+        """Initialize EmailNotifier class
 
         Args:
-            username (str): Username of the gmail account to use for sending message.
-            password (str): Password of the gmail account to use for sending message.
+            smtp_server (str): Smtp server address in form host:port
+            username (str): Username of the email account to use for sending message.
+            password (str): Password of the email account to use for sending message.
             destination_addresses (list): A list of email addresses to notify.
         """
 
         self.logger = structlog.get_logger()
-        self.smtp_server = 'smtp.gmail.com:587'
+        self.smtp_server = smtp_server
         self.username = username
         self.password = password
         self.destination_addresses = ','.join(destination_addresses)

docs/config.md

@@ -145,34 +145,40 @@ notifiers:
             template: "{{exchange}}-{{market}}-{{indicator}}-{{indicator_number}} is {{status}}!{{ '\n' -}}"
 ```
 
-## Gmail
+## Email
+**smtp_server**\
+default: None\
+necessity: required for Email\
+description: Your smtp server hostname
+
 **username**\
 default: None\
-necessity: required for Gmail\
-description: Your gmail username which is required for sending emails.
+necessity: required for Email\
+description: Your email username which is required for sending emails.
 
 **password**\
 default: None\
-necessity: required for Gmail\
-description: Your gmail password which is required for sending emails.
+necessity: required for Email\
+description: Your email password which is required for sending emails.
 
 **destination_emails**\
 default: None\
-necessity: required for Gmail\
+necessity: required for Email\
 description: The email addresses to receive the emails that are sent.
 
 **template**\
 default: {{exchange}}-{{market}}-{{analyzer}}-{{analyzer_number}} is {{status}}!{{ '\n' -}}\
 necessity: optional\
 description: See the notifier templating section.
 
-An example of notifier settings for gmail
+An example of notifier settings for email
 
 ```yml
 notifiers:
-    gmail:
+    email:
         required:
-            username: [email protected]
+            smtp_server: smtp.gmail.com:587
+            username: [email protected]
             password: abcd1234
             destination_emails:
                 - [email protected]